Added event_file_check to check syntax of phoenix event files #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this has been tested only with LHCb data, so things like Jets or (non planar) Calo Cells have been poorly checked. |
|
@9inpachi @EdwardMoyse for info |
|
Thanks @sponce. This will be very helpful! We can check all the JSON event data files we have in the main repo to see if it works for all of them. We may even find issues in the data itself. |
|
This certainly fails on the ATLAS events... I'm investigating. |
Also added associated documentation
sponce
force-pushed
the
sponce_event_file_checker
branch
from
55b3e99
to
8431987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added associated documentation