Adding support for IrregularCaloCells physics objects

[nilotpal09]

Calorimeter cells with arbitrary polyhedron-type geometry.
Each cell is represented by 8 (x,y,z) vertices connected using a convex hull from the ConvexGeometry class.

IrregularCaloCells is a list of objects with the following attributes :

• layer - the Calorimeter layer
• vtx - a flattened list of 8 vertex coordinates (24 floats)
• color - an integer list of [R,G,B] values
• opacity - value from 0 to 1

[nilotpal09]

tagging @etiennedreyer

[9inpachi]

Thanks a lot for the PR! I am sure this new physics object works as intended but I added a few comments for some Phoenix specific things that may not have been clear.

[EdwardMoyse]

Another comment - it seems like the linting check failed:

/home/runner/work/phoenix/phoenix/packages/phoenix-event-display/src/loaders/phoenix-loader.ts
  304:21  error  Replace `⏎········new·Cut('layer',·0,·10),⏎······` with `new·Cut('layer',·0,·10)`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

If you're using Visual Studio Code, you can add the prettier plugin and then 'Format Document' with this linting tool.

Edit: I should have also linked to the documentation:
https://github.com/HSF/phoenix/blob/main/CONTRIBUTING.md#code-formatting

[etiennedreyer]

Hi @9inpachi thanks for reviewing and suggesting the changes. We implemented them.
@EdwardMoyse we ran the linting, and we also added an option for cut based on cell energy.
Let us know if there's any other issue/request.

[EdwardMoyse]

No objections from my side, but I'll let @9inpachi comment too.

[9inpachi]

Looks good to me too. Thanks for making the changes. :)

[sponce]

There is no uuid in irrCells ! So my ci (LHCb's deployment one) gives the following error :

src/loaders/objects/phoenix-objects.ts(834,14): error TS2339: Property 'uuid' does not exist on type '{ type: any; layer: number; vtx: any; color: string; opacity: any; }'.

I do not get why we did not see it in the official repo ! Can you fix it ?

[etiennedreyer]

Hi @sponce we looked together and are not fully sure how to address this. We checked that the browser runs for us (with and without IrregularCaloCells) before pushing, but somehow it's not working the LHCb ci.
Should we just add the following line here?
uuid: string;

[sponce]

In the meantime, we've identified what might be the reason for different behavior in LHCb : we somehow use threejs 148 rather than 147. So I suppose moving back to 147 would make it work for us.

On the other hand, the code in indeed weird, as you set a member that does not exist. So indeed, I would add uuid:string or alternatively drop the line setting the uuid if it's not used. But I suppose it is in your case (for lhcb, I did that stop gap fix yesterday and it worked)