You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sync_behav_out, sync_neural_out = match_pulses(sync_behav, sync_neural, n_pulses=500, start_offset=100)
Change start_offset number has a significant effect on the output
As of scipy version 1.9.0, there is a new 'keepdims' argument in scipy.stats.mode that needs to be set for future-proofing, and will start to fail in scipy version 1.11.0: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.mode.html
This relates to the use of scipy.stats.mode here:
https://github.com/HSUPipeline/convnwb/blob/main/convnwb/timestamps/align.py#L168
For future scipy usage, this could be updated to:
ixis_mode = stats.mode(ixis, keepdims=True)[0][0]
Or, equivalent updates:
ixis_mode = stats.mode(ixis, keepdims=True).mode[0]
ixis_mode = stats.mode(ixis, keepdims=False).mode
Basically - the fix is easy, but need to decide whether to enforce a specific version of scipy, and/or do a version check.
The text was updated successfully, but these errors were encountered: