Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create pull request to v3 #1096

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Update create pull request to v3 #1096

merged 2 commits into from
Jul 25, 2020

Conversation

tunetheweb
Copy link
Member

@tunetheweb tunetheweb commented Jul 25, 2020 •
edited
Loading

@tunetheweb tunetheweb added the development Building the Almanac tech stack label Jul 25, 2020
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Jul 25, 2020
@tunetheweb tunetheweb added this to TODO in 2020 via automation Jul 25, 2020
ibnesayeed
ibnesayeed approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a couple of inline comments, but those are trivial. Other than those, this LGTM!

.github/workflows/generate_chapters.yml Show resolved Hide resolved
.github/workflows/generate_chapters.yml Outdated Show resolved Hide resolved
2020 automation moved this from TODO to In progress Jul 25, 2020
@tunetheweb @ibnesayeed
Revert multi-line label change
230113d 
Co-authored-by: Sawood Alam <ibnesayeed@gmail.com>
@tunetheweb
Copy link
Member Author

Thanks @ibnesayeed !

@tunetheweb tunetheweb merged commit b75cb73 into main Jul 25, 2020
2020 automation moved this from In progress to Done Jul 25, 2020
@tunetheweb tunetheweb deleted the upgrade_create_pull_request branch July 25, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibnesayeed ibnesayeed ibnesayeed approved these changes

Assignees
No one assigned
Labels
development Building the Almanac tech stack
Projects
No open projects
2020
  
Done
Milestone
2019 Backlog
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tunetheweb @ibnesayeed