Allow language and country code languages when choosing best site for visitor #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
added
development
rviscomi
reviewed
Jul 27, 2020
rviscomi
approved these changes
Jul 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the different Chinese languages (
zh-CNandzh-TW) first check language and country code rather than just language.Fall back to language only (
zh) if needs be but most browsers are configured to have both country specific, and then generic so this fallback is unlikely to be used. MyAccept-Languageheader for example includes British English, American English and then just English:This is only used when visiting the top level site (https://almanac.httparchive.org/) so extra processing time is not a concern.