Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes copyright year from footer #1112

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Removes copyright year from footer #1112

merged 2 commits into from
Jul 27, 2020

Conversation

SaptakS
Copy link
Collaborator

@SaptakS SaptakS commented Jul 27, 2020

Fixes #948

rviscomi
rviscomi approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rviscomi rviscomi added the development Building the Almanac tech stack label Jul 27, 2020
@rviscomi rviscomi added this to TODO in 2020 via automation Jul 27, 2020
@rviscomi rviscomi added this to the 2019 Backlog milestone Jul 27, 2020
@tunetheweb
Copy link
Member

Good stuff! Can you submit a PR to add yourself to src/config/2020.json in development team? They are in alphabetical order by first name btw.

You can do this either as part of this PR or as a separate one.

@rviscomi
Copy link
Member

Aside: @bazzadp can we have a linter that checks that the contributor was added in the right sort order? 😅

@tunetheweb tunetheweb mentioned this pull request Jul 27, 2020
Merged
@tunetheweb
Copy link
Member

Aside: @bazzadp can we have a linter that checks that the contributor was added in the right sort order? 😅

My OCD suffices for that for now 😁

@SaptakS
Copy link
Collaborator Author

SaptakS commented Jul 27, 2020

Good stuff! Can you submit a PR to add yourself to src/config/2020.json in development team? They are in alphabetical order by first name btw.

You can do this either as part of this PR or as a separate one.

I will add it as part of this PR itself.

2020 automation moved this from TODO to In progress Jul 27, 2020
@tunetheweb tunetheweb merged commit 4c864d5 into HTTPArchive:main Jul 27, 2020
2020 automation moved this from In progress to Done Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
development Building the Almanac tech stack
Projects
No open projects
2020
  
Done
Milestone
2019 Backlog
Development

Successfully merging this pull request may close these issues.

Remove the year from the footer copyright
3 participants
@SaptakS @tunetheweb @rviscomi