Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirects when chapter does not exist in that language for that year #1117

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

tunetheweb
Copy link
Member

Currently redirects to home page (with a 301 instead of a 302!) when it should redirect to English version if it exists.

Bug due to checking for existence based on URL, rather than template.

@tunetheweb tunetheweb added bug Something isn't working translation world wide web labels Jul 28, 2020
@tunetheweb tunetheweb added this to the 2019 Backlog milestone Jul 28, 2020
@tunetheweb tunetheweb added this to TODO in 2020 via automation Jul 28, 2020
Copy link
Collaborator

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2020 automation moved this from TODO to In progress Jul 29, 2020
@tunetheweb tunetheweb merged commit 7847df6 into main Jul 29, 2020
2020 automation moved this from In progress to Done Jul 29, 2020
@tunetheweb tunetheweb deleted the display_english_chapter_if_no_translation branch July 29, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working translation world wide web
Projects
No open projects
2020
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants