Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chinese language selector #1128

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Fix Chinese language selector #1128

merged 2 commits into from
Jul 30, 2020

Conversation

tunetheweb
Copy link
Member

We currently have this:

Drop down arrow covers Chinese language

When we should have this:

Drop down arrow to right of Chinese language

Wish there was a way of coding this based on length of current option selected, but select elements has very little styling support. Hopefully be fixes properly by #986 but this'll do for now.

@tunetheweb tunetheweb added bug Something isn't working development Building the Almanac tech stack translation world wide web labels Jul 30, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Jul 30, 2020
@tunetheweb tunetheweb added this to TODO in 2020 via automation Jul 30, 2020
@rviscomi
Copy link
Member

Weird! What is it about these characters that make the <select> shrink?

@tunetheweb
Copy link
Member Author

It's not so much the <select> shrinking - it's the fact we have the drop down arrow as an ::after element and use absolute position to bring it into the <select> circle. So it is a bit of a magic number to give it that space but not too much space.

Plus <selects> really are the unloved children of the CSS world!

2020 automation moved this from TODO to In progress Jul 30, 2020
@tunetheweb tunetheweb merged commit d8452fc into main Jul 30, 2020
2020 automation moved this from In progress to Done Jul 30, 2020
@tunetheweb tunetheweb deleted the chinese_lang_dropdown branch July 30, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development Building the Almanac tech stack translation world wide web
Projects
No open projects
2020
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants