Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some missed Japanese translations #1160

Merged
merged 8 commits into from
Aug 7, 2020
Merged

Some missed Japanese translations #1160

merged 8 commits into from
Aug 7, 2020

Conversation

ksakae1216
Copy link
Contributor

@ksakae1216 ksakae1216 commented Aug 5, 2020 •
edited by tunetheweb
Loading

Please review.

Fixes #1158

@ksakae1216 ksakae1216 added the translation world wide web label Aug 5, 2020
@ksakae1216 ksakae1216 added this to TODO in 2020 via automation Aug 5, 2020
@rviscomi rviscomi added this to the 2019 Backlog milestone Aug 5, 2020
tunetheweb
tunetheweb approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some small nits about spaces to remove.

src/templates/ja/2019/contributors.html Outdated Show resolved Hide resolved
src/templates/ja/2019/index.html Outdated Show resolved Hide resolved
src/templates/ja/2019/index.html Outdated Show resolved Hide resolved
src/templates/ja/2020/contributors.html Outdated Show resolved Hide resolved
src/templates/ja/2020/index.html Outdated Show resolved Hide resolved
src/templates/ja/2020/index.html Outdated Show resolved Hide resolved
2020 automation moved this from TODO to In progress Aug 5, 2020
@tunetheweb tunetheweb changed the title translate of japanese Some missed Japanese translations Aug 5, 2020
@tunetheweb
Copy link
Member

@ksakae1216 as those are the only things keeping this from being merged, I'll just commit them now and merge this. Hope that's OK.

@tunetheweb tunetheweb merged commit e7503e2 into HTTPArchive:main Aug 7, 2020
2020 automation moved this from In progress to Done Aug 7, 2020
@ksakae1216 ksakae1216 deleted the delete-the-japanese branch August 8, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
translation world wide web
Projects
No open projects
2020
  
Done
Milestone
2019 Backlog
Development

Successfully merging this pull request may close these issues.

Still some English in Japanese templates
3 participants
@ksakae1216 @tunetheweb @rviscomi