Remove run_queries.sh as no longer used #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's remove it. The intent behind the script was to generate JSON results for each SQL file to be used for data viz, but we ended up with (and continue to use) Sheets for that. JSON needed for one-off data viz like #896 can be created manually from BQ.
This is a normal error message as the queries should be billed back to the GCP project and only HTTP Archive admins can do that. I didn't want anyone accidentally running this script on their personal GCP projects and incurring $$$. |
tunetheweb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a bash linter in #1177 however the run_queries.sh is throwing up some errors. Not sure if this is even used but this fixes it in case it is used, or needed in the future.
@rviscomi / @paulcalvano can you test this?
When I try to run
./run_queries.sh 2019/19_Resource_HintsI get the below produced in the JSON files:So not 100% sure it's actually working. Or can you give me access so I can test it?
Or if it's not used, then I could just change this PR to delete this file instead as it's the only one failing our linting at the moment when I lint the whole repo.