Add Flake8 Python linter #1187
Merged
Add Flake8 Python linter #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibnesayeed
approved these changes
Aug 9, 2020
There was a problem hiding this comment.
LGTM!
I don't think there is anything wrong in running both. There is a good conversation on this topic.
rviscomi
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have PyLint enabled, but our code base now also passes Flake8 linting so I think we should enable it too.
What's people's thoughts - two linters overkill?
There were somethings picked up by Flake8 that were missed by PyLint (and I'm sure it would be the case the other way round too, the config is minimal, and it takes seconds to run so I say add it.
What do the rest of you think?