Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HTML in Big Issues #1518

Merged
merged 2 commits into from Nov 14, 2020
Merged

Allow HTML in Big Issues #1518

merged 2 commits into from Nov 14, 2020

Conversation

tunetheweb
Copy link
Member

As noticed in #539 (comment) we've a bug:

image

@tunetheweb tunetheweb added bug Something isn't working development Building the Almanac tech stack labels Nov 14, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Nov 14, 2020
@tunetheweb tunetheweb added this to TODO in 2020 via automation Nov 14, 2020
@tunetheweb tunetheweb mentioned this pull request Nov 14, 2020
Open
2020 automation moved this from TODO to In progress Nov 14, 2020
rviscomi
rviscomi approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@rviscomi rviscomi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to fix this specific case, but I think it's worth reevaluating why   characters are needed in general. If to prevent "%" from wrapping, can't we use CSS white-space: nowrap?

@tunetheweb
Copy link
Member Author

tunetheweb commented Nov 14, 2020 •
edited

It's a French thing as they use spaces between figure and % and figure and units. Yes in this case we should use no wrap but in general text we can't (unless we wrap each figure in a span which is more wordy than  ) so it's used all over their translations.

@tunetheweb tunetheweb merged commit 2613629 into main Nov 14, 2020
2020 automation moved this from In progress to Done Nov 14, 2020
@tunetheweb tunetheweb deleted the french_figure_issue branch November 14, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rviscomi rviscomi rviscomi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working development Building the Almanac tech stack
Projects
No open projects
2020
  
Done
Milestone
2020 Platform Development
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tunetheweb @rviscomi