New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed position chapter CTAs #2196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent work @AbbyTsai - works really well!
I've made some suggestions below.
@HTTPArchive/designers do you have any opinions here? I've put a test version here that you can play with: https://20210511t182132-dot-webalmanac.uk.r.appspot.com
|
Thanks. Barry. happy to see the test version and feel free to add anything below together. Here's some consolidated points would love to have all your thoughts. @rviscomi @HTTPArchive/designers 5 CTAs (2 new, 3 alive): call to action (CTA) and hopefully be visible by readers. CTA1:Comments (alive) CTA2:suggest edit (new) CTA3:help translate (new) Purpose: increase readers' engagement.
|
thanks all the warm, helpful recommendations. |
Looks like GitHub is experiencing issues: https://www.githubstatus.com/incidents/zbpwygxwb3gw Will rerun them again later. |
Thanks to the information and hope to see a lovely v here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the position: sticky
changes but spotted a few issues and think we can make it even smoother. Let me know what you think.
Yep, cool idea. These horizonal CTAs play the role gently, but a little thought comes to the mind, would we seemingly put the same buttons both at the end of article and explore result in screen? |
Yeah I'm not loving that to be honest: But I do like that they stop scrolling down at a point, rather than covering the other buttons and/or footer. I think it's cleaner than what we originally had. As I say, the options are:
@HTTPArchive/designers or @HTTPArchive/developers any thoughts here? Or anyone with between CSS/JS knowledge than me that could make this work better? You can see the current implementation on this demo deploy. |
Having all the options under the "Explore your Options" section also gives options to reduce the floating CTAs if we want in certain circumstances:
It's always nice to have options 😁 |
@rviscomi @tunetheweb @shantsis 1.Where's CTAs position? 2.Where's CTAs scrolling area? 3.What's CTAs collapsed look? 4.What's in explore result? |
I wonder if we're trying to over use this. Do we really need "Help Translate" available at all times? And it's fairly common to have "Suggest Edit" just at the end rather than available at all times. Yes we could hide in a menu, but a menu means we're hiding the comments again - and primary aim of this was to increase that engagement I think. We also wanted to increase interaction with the stats but the availability of those by each figure does that job IMHO. So I'm wondering if we should leave this as just the comments? That would keep it's size to a minimum and also avoid any concerns about it covering content or repeating the "Explorer the results" section: Test deploy with just that: https://20210522t125050-dot-webalmanac.uk.r.appspot.com Mobile: Desktop: |
Had to do some other changes so committed my additions to this branch so they wouldn't be lost. Hope you don't mind @AbbyTsai ! |
Really like the lately test version where most focus on the comment CTA via discuss. Would appreciate if it's committed as well, as a little bit confused the changes. Think that if we still wanna to raise the helper of chapter translate or make it easier to open issue via GitHub, then we might use icon of comment instead of menu and then 3 dedicated icons display by click. Would that collapsed icon attract readers' eye as well? OR we may focus on one comment CTA only. It seemingly depends on our ambition. ^^ |
It's still not keyboard accessible. Nor does it add the appropriate aria attributes necessary for screen-readers.
Another reason not to try a pure CSS solution.
Well that's the trick! It's a combination of what's the best solution for the users (this should be the primary concern!), what's the easiest and cleanest to code, and how maintainable it is in the future. Adding a library is easy, but can add bloat, and add future work to maintain it as it changes. So need to be sure it's worth it. We've (only half consciously) tried to avoid libraries for the Web Almanac site itself (though do use lots for our build process) as it's a fairly simple site at the end of the day and not needed them. |
1 similar comment
It's still not keyboard accessible. Nor does it add the appropriate aria attributes necessary for screen-readers.
Another reason not to try a pure CSS solution.
Well that's the trick! It's a combination of what's the best solution for the users (this should be the primary concern!), what's the easiest and cleanest to code, and how maintainable it is in the future. Adding a library is easy, but can add bloat, and add future work to maintain it as it changes. So need to be sure it's worth it. We've (only half consciously) tried to avoid libraries for the Web Almanac site itself (though do use lots for our build process) as it's a fairly simple site at the end of the day and not needed them. |
Thanks Barry for the nice sharing in development principle of user first and warm sample in JS version. Happy to see these CTAs would help our users find an easy way to get involved by the articles. Not quiet sure if we try to add a role, aria attributes to its html element on css:mouse over, does then the screen read the missing keyboard? or? In summary, love to see our mouse-click button alive if experience show users enjoy it, or it's a better way to keyboard accessible. |
Mouse over doesn’t work for keyboard or mobile users. Also it’s very easy to hover away by accident and then you lose the menu. Best to just do it on click. Then it’s easy to add the necessary ARIA attributes as well. There’s been a fair bit of research on this (see links in answer to this question for just some of them). Bootstrap 4 for example moved from hover menus to click menus. |
Can’t a mouse over action also be triggered by on keyboard focus? It may be a bit more work but doesn’t have to be a click. |
Yes it can but doesn’t address mobile or the ARIA requirements. The reality is we need JavaScript to make accessible menus at present. And, given that this is a progressive enhancement of the “Explore the results” section that’s not a bad thing. So what’s the reason for not using JavaScript? |
Interesting article on this topic which has just been published: https://www.smashingmagazine.com/2021/06/css-javascript-requirements-accessible-components/ |
This pull request is dragging out, and growing arms and legs as we add more features, complexity and opinions to it. I'm thinking we should merge it as is, and then iterate upon it. What do you think @AbbyTsai / @rviscomi / @shantsis ? As a reminder the current code in this branch is basically a floating comments widget for mobile and desktop and some extra calls to action in the Explore the Results section. It can be seen here: https://20210614t202814-dot-webalmanac.uk.r.appspot.com/en/2020/fonts. I think these are good features, that are beneficial and are mergeable as is. We can add the extra ideas (expandable menu with more options) in a new branch and pull request. One thing I'd like to do is before merging, is internationalise it, but I am happy to do that and commit to this branch if you've not moved it forward offline @AbbyTsai ? Let me know your thoughts. |
Design wise it seems fine for now. I was trying it on my mobile and was struggling quite a lot to activate it - see the video linked. https://drive.google.com/file/d/1Fhh9gR7zi50X3KdlolNYE6KEflFzyShf/view?usp=drivesdk |
Oh good spot! Moving to bottom we can make it work regardless of whether menu is showing or not. Try this: https://20210614t205125-dot-webalmanac.uk.r.appspot.com/en/2020/fonts |
Much better thanks 😊 |
Merge and iterate SGTM! |
I've added the internalisation pieces so think this is good to merge now. @AbbyTsai let me know your thoughts before I do that. |
Oh and latest staged version: https://20210615t003135-dot-webalmanac.uk.r.appspot.com/en/2020/fonts |
Great to see it and warm thanks to all support by Barry, Shantsis, Rick. |
progress on Fixed position chapter CTAs #1617