Take Effective Connection Type into account when upgrading to interactive visuals #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ade to interactive visuals
rviscomi
requested changes
Nov 25, 2019
rviscomi
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at Effective Connection Type and use that as part of the decision making as to whether to upgrade to Sheets interactive visuals or stay on images.
At the moment I say
slow-2g,2gor3gis low bandwidth and everything else (including when ECT is not reported) is high bandwidth. That seem about right or should we include3gas high bandwidth too?Also includes a small bug fix for IE11 that currently bails on the fetch call (even though fetch is not supported) and so fails to upgrade to Sheets visuals. This won't be needed once #511 is merged but putting it in there for now anyway.