-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation of Accessibility chapter to Japanese #609
Translation of Accessibility chapter to Japanese #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MSakamaki can you fix the line breaks so they are identical to the English chapter? It will make it easier to keep these chapters in sync (particularly for any technical changes required to the markdown from non-Japanese speakers).
At the moment you can see the line numbers are out of sync:
Other than that, I made a few comments for you to consider. Feel free to reject them if that's not the way things are normally done in Japanese translations.
After that can you review please @ksakae1216 ?
@bazzadp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a technical point of view. Once @ksakae1216 approves language we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comment.
Plz confirm.
Thanks review @ksakae1216! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks fix.
Thanks both! |
accessibility chapter translated into Japanese
Part of #586