Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of Accessibility chapter to Japanese #609

Merged
merged 4 commits into from
Jan 6, 2020
Merged

Translation of Accessibility chapter to Japanese #609

merged 4 commits into from
Jan 6, 2020

Conversation

MSakamaki
Copy link
Contributor

@MSakamaki MSakamaki commented Dec 30, 2019 •
edited by tunetheweb

accessibility chapter translated into Japanese

Part of #586

@MSakamaki MSakamaki requested review from ksakae1216 and a team December 30, 2019 04:48
@MSakamaki MSakamaki added the translation world wide web label Dec 30, 2019
@tunetheweb tunetheweb changed the title fixed accessibility japanese translation Translation of Accessibility chapter to Japanese Dec 30, 2019
@tunetheweb tunetheweb added this to TODO in Web Almanac 2019 via automation Dec 30, 2019
tunetheweb
tunetheweb requested changes Dec 30, 2019
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSakamaki can you fix the line breaks so they are identical to the English chapter? It will make it easier to keep these chapters in sync (particularly for any technical changes required to the markdown from non-Japanese speakers).

At the moment you can see the line numbers are out of sync:

image

Other than that, I made a few comments for you to consider. Feel free to reject them if that's not the way things are normally done in Japanese translations.

After that can you review please @ksakae1216 ?

src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/ja/2019/accessibility.md Show resolved Hide resolved
src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
@MSakamaki
Copy link
Contributor Author

@bazzadp
Except for #609 (comment), I fixed it all.

tunetheweb
tunetheweb approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical point of view. Once @ksakae1216 approves language we can merge.

ksakae1216
ksakae1216 reviewed Jan 4, 2020
View reviewed changes
Copy link
Contributor

@ksakae1216 ksakae1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comment.
Plz confirm.

src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/ja/2019/accessibility.md Show resolved Hide resolved
src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
src/content/ja/2019/accessibility.md Outdated Show resolved Hide resolved
@MSakamaki
Copy link
Contributor Author

Thanks review @ksakae1216!
Please check it again because it has fixed.

ksakae1216
ksakae1216 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@ksakae1216 ksakae1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fix.

@tunetheweb tunetheweb merged commit 1850d92 into HTTPArchive:master Jan 6, 2020
Web Almanac 2019 automation moved this from TODO to Done Jan 6, 2020
@tunetheweb
Copy link
Member

Thanks both!

@tunetheweb tunetheweb added accessibility Accessibility related and removed accessibility Accessibility related labels Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksakae1216 ksakae1216 ksakae1216 approved these changes

@tunetheweb tunetheweb tunetheweb approved these changes

Assignees
No one assigned
Labels
translation world wide web
Projects
No open projects
Web Almanac 2019
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MSakamaki @tunetheweb @ksakae1216