Added hreflang alternate tags #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AymenLoukil
added
development
rviscomi
requested changes
Jul 4, 2019
src/templates/base.html
Outdated
| @@ -25,6 +25,10 @@ | |||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Open+Sans:300,400,600,700,800"> | |||
| <link rel="stylesheet" href="/static/css/styles.css"> | |||
| {% endblock %} | |||
| {% set view_args = request.view_args.copy() %} | |||
There was a problem hiding this comment.
The indentation here is inconsistent. Could you match the rest of the file?
There was a problem hiding this comment.
OK i'll correct.
There was a problem hiding this comment.
Looks like they're one nested level too many. Everything should be aligned with the blocks/links before it.
There was a problem hiding this comment.
Already corrected in the new commit no ?
There was a problem hiding this comment.
See screenshot below. New changes are too far indented:
There was a problem hiding this comment.
Thanks. I think it ok now :)
rviscomi
approved these changes
Jul 8, 2019
rviscomi
added a commit
that referenced
this pull request
Jul 12, 2019
* Language class * fix tests * Added hreflang alternate tags (#74) * add link alternate hreflang tags * correct indentation * second try to correct indentation .. * update view args in template method * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked out your branch "lang". Please tell me if i should wait your PR merge :)
I loop over the available languages and add the link alternate tags to the head (on base.html). Sounds working
Fixes #61