fix imagesrcset bug #133
Merged
fix imagesrcset bug #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28% of Angular 17 apps using the image directive have been missing performance data due to errors. Looking into it, it seems that `link.imagesrcset` is undefined in some of these cases. Grabbing the attribute instead of the prop with `link.getAttribute` fixes the issue. See example failure: https://www.webpagetest.org/result/240618_AiDc8Y_E9D/3/details/ See example fix: https://www.webpagetest.org/result/240618_AiDcZ3_E78/2/details/
tunetheweb
reviewed
Jun 18, 2024
Co-authored-by: Barry Pollard <barrypollard@google.com>
tunetheweb
reviewed
Jun 18, 2024
Co-authored-by: Barry Pollard <barrypollard@google.com>
Custom metrics for https://almanac.httparchive.org/en/2022/WPT test run results: http://webpagetest.httparchive.org/results.php?test=240618_G6_6 {}Custom metrics for https://exploreti.com/WPT test run results: http://webpagetest.httparchive.org/results.php?test=240618_DQ_7 {} |
tunetheweb
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
28% of Angular 17 apps using the image directive have been missing performance data due to errors. Looking into it, it seems that
link.imagesrcsetis undefined in some of these cases. Grabbing the attribute instead of the prop withlink.getAttributefixes the issue.See example failure: https://www.webpagetest.org/result/240618_AiDc8Y_E9D/3/details/
See example fix: https://www.webpagetest.org/result/240618_AiDcZ3_E78/2/details/
Test websites: