Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of the OWL file for OLS #295

Merged
merged 26 commits into from
Jul 16, 2024
Merged

Conversation

ypriverol
Copy link
Contributor

@mobiusklein @edeutsch :

I have tried to get an action workflow that validates the OWL. Unfortunately, the code they have downloads the files from the given path and does not allow to pass files for validation. Then, we will need to validate existing PRs, unless we release the OBO file first into a branch and then validate there and PR into master. The current version of the OWL file is still failing BTW. The workflow does the following:

  • Download the dataload tool from OLS4 which is the tool that loads the ontologies.
  • Build the tool.
  • Download a config file that only contains our ontology to be validated.
  • Perform the conversion/validation from RDF2JSON (really don't understand what they are trying to achieve, but is where we are failing).
  • Compare the output file with a given file with validation and empty file, if they are equal, then we are not passing "validation"

Copy link
Contributor

@mobiusklein mobiusklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this load the same tree of configurations that OLS does?

owl-config-ols/foundry.json Show resolved Hide resolved
.github/workflows/validate-owl.yaml Show resolved Hide resolved
@mobiusklein
Copy link
Contributor

Thank you for setting this up. It looks like it is doing what we need it to, I have to get to work, but will come back to this when I have time later today.

@ypriverol
Copy link
Contributor Author

ypriverol commented Jul 13, 2024

@mobiusklein I think the validation is ready. You can see here how the validation works. With the current OWL, it works.

@mobiusklein In addition I added some extra work to organize the repo, the documentation, the CI/CD and badges to make it clear when something doesn't work.

Copy link
Contributor

@mobiusklein mobiusklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight adjustment to the README but this looks good to me.

@mobiusklein mobiusklein added this pull request to the merge queue Jul 16, 2024
Merged via the queue into HUPO-PSI:master with commit fa3e11c Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants