-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation of the OWL file for OLS #295
Conversation
# Conflicts: # psi-ms.obo
# Conflicts: # psi-ms.obo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this load the same tree of configurations that OLS does?
Thank you for setting this up. It looks like it is doing what we need it to, I have to get to work, but will come back to this when I have time later today. |
@mobiusklein I think the validation is ready. You can see here how the validation works. With the current OWL, it works. @mobiusklein In addition I added some extra work to organize the repo, the documentation, the CI/CD and badges to make it clear when something doesn't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a slight adjustment to the README
but this looks good to me.
@mobiusklein @edeutsch :
I have tried to get an action workflow that validates the OWL. Unfortunately, the code they have downloads the files from the given path and does not allow to pass files for validation. Then, we will need to validate existing PRs, unless we release the OBO file first into a branch and then validate there and PR into master. The current version of the OWL file is still failing BTW. The workflow does the following: