Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign HWKeyCrypter #2

Open
7 tasks done
oliveraemmer opened this issue Feb 24, 2024 · 1 comment
Open
7 tasks done

Redesign HWKeyCrypter #2

oliveraemmer opened this issue Feb 24, 2024 · 1 comment
Assignees
@iSavicx

Comments

@oliveraemmer
Copy link

oliveraemmer commented Feb 24, 2024 •
edited
Loading

  • Implement in bitcoin-wallet or bitcoinJ?
    -> bitcoin-wallet

Implement and redesign current HWKeyCrypter

  • Copy HWKeyCrypter from Project 2
  • Add biometric authentication when creating the KeyStore instance
  • Error handling if the phone does not support biometric auth
  • Handle unused password in deriveKey() method (add clear information in the comments that the password is unused)
  • Handle KeyStore key reference (Store key reference as class field and return it as AesKey in deriveKey())
  • Access KeyStore based on provided AesKey key reference in decrypt() and encrypt()
@oliveraemmer
Copy link
Author

Handle KeyStore key reference (Store key reference as class field and return it as AesKey in deriveKey())
-> Reference is implemented as application constant

oliveraemmer pushed a commit that referenced this issue Apr 9, 2024
@oliveraemmer
# This is a combination of 24 commits.
92ae3d2 
# This is the 1st commit message:

added new strings for upcoming keystore support

# This is the commit message #2:

moved from spending pin menu to wallet protection menu

# This is the commit message #3:

added prototype for supporting keystore and spending pin in a dialog fragment

# This is the commit message #4:

KeyStoreKeyCrypter with biometric authentication (#9)

* implemented new KeyStoreKeyCrypter and biometric authentication, untested

* added KeyStore features

# This is the commit message #5:

added a working version that supports both keycrypters without user biometric authentication

# This is the commit message #6:

small change*

# This is the commit message #7:

wip

# This is the commit message #8:

working version for encrypt but decrypt only works if its in the timout period. if decrypt needs to authenticate the user the app freezes i.e. the UI thread doesn't responde

# This is the commit message #9:

wip

# This is the commit message #10:

rebase2

# This is the commit message #11:

upgrade build successful, not tested

# This is the commit message #12:

rebase

# This is the commit message #13:

fixed tx declaration

# This is the commit message #14:

rebase

# This is the commit message #15:

rebase

# This is the commit message #16:

wip, implemented KeyCrypterFactory

# This is the commit message #17:

backup with keystorekeycrypter


# This is the commit message #18:

small changes for 0.17 upgrade + context propagation in cryptactivity

# This is the commit message #19:

sending funds when keystore encrypted fix

# This is the commit message #20:

removed button from CryptActivity, fixed backup export and import

# This is the commit message bitcoin-wallet#21:

added strings

# This is the commit message bitcoin-wallet#22:

fixed backup with keystore

# This is the commit message bitcoin-wallet#23:

added string resources and new EncryptionType

# This is the commit message bitcoin-wallet#24:

removed scrypt params from KeyStoreKeyCrypter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iSavicx iSavicx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iSavicx @oliveraemmer