Proposal for HWKeyCrypter and Biometric Authentication #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliveraemmer
force-pushed
the
keystore
branch
2 times, most recently
from
04d8ddc
to
3dddfc3
Compare
oliveraemmer
force-pushed
the
bitcoinj_update
branch
from
6952bb6
to
6ed6250
Compare
oliveraemmer
force-pushed
the
keystore
branch
2 times, most recently
from
40415d8
to
fdd73a5
Compare
oliveraemmer
changed the title
oliveraemmer
force-pushed
the
keystore
branch
2 times, most recently
from
444792e
to
8e301ff
Compare
Open
oliveraemmer
force-pushed
the
bitcoinj_update
branch
from
6ed6250
to
31c78f7
Compare
oliveraemmer
force-pushed
the
keystore
branch
2 times, most recently
from
894a9bf
to
517740d
Compare
Co-authored-by: Sebastian Nicol <sebastian.r.nicol@gmail.com> Co-authored-by: Oliver Aemmer <oliver.aemmer@protonmail.ch>
…le attack vector. Co-authored-by: Sebastian Nicol <sebastian.r.nicol@gmail.com> Co-authored-by: Oliver Aemmer <oliver.aemmer@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the keys in the wallet can be encrypted using a spending pin. With this PR we propose a new encryption type which leverages the Android KeyStore and Biometric Authentication to encrypt the keys. It is not a replacement of the spending pin but an addition.
This change requires additional changes in bitcoinj. The files in wallet/libs/ are built from the proposal_keycrypterfactory_new_encryptiontype branch.
With Android Studio 2022.3.1 Patch 2 this current settings should build without additional changes
Change log: