Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for KeyCrypterFactory and new EncryptionType #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oliveraemmer
Copy link

@oliveraemmer oliveraemmer commented Apr 3, 2024

This PR proposes the implementation of a KeyCrypterFactory which allows users of the library to import their own KeyCrypters using their own EncryptionTypes. Currently this only works by extending the KeyCrypterScrypt class.

Change log:

  • Add KeyCrypterFactory which can be set in WalletProtobufSerializer
  • Add encryptionType field in EncryptedData
  • Add Protos.Wallet.EncryptionType ENCRYPTED_KEYSTORE_AES in wallet.proto
  • BasicKeyChain and DeterministicKeyChain: Check if one of the wallet encryption types is set
  • DeterministicSeed: Return the encryptionType of the EncryptedData
  • WalletProtobufSerializer: Use KeyCrypter provided by KeyCrypterFactory if the new encryption type ENCRYPTED_KEYSTORE_AES is defined in the protobuf

oliveraemmer and others added 2 commits April 17, 2024 10:45
Co-authored-by: Sebastian Nicol <sebastian.r.nicol@gmail.com>
Co-authored-by: Oliver Aemmer <oliver.aemmer@protonmail.ch>
@oliveraemmer oliveraemmer force-pushed the proposal_keycrypterfactory_new_encryptiontype branch from 02b52e4 to 3937c2e Compare April 17, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant