Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

Commit

Permalink
Remove eslint in favor of standard.js
Browse files Browse the repository at this point in the history
… standardjs is based on eslint but a way better option.

https://standardjs.com/
  • Loading branch information
HaNdTriX committed Jul 30, 2017
1 parent 6feca4f commit 4e68a2d
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 36 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
![generator-chrome-extension-kickstart](images/chrome-extension-kickstarter-intro.png)

[![Build Status](https://secure.travis-ci.org/HaNdTriX/generator-chrome-extension-kickstart.png?branch=master)](https://travis-ci.org/HaNdTriX/generator-chrome-extension-kickstart) [![npm package](https://badge.fury.io/js/generator-chrome-extension-kickstart.svg)](https://www.npmjs.com/package/generator-chrome-extension-kickstart)
[![js-standard-style](https://img.shields.io/badge/code%20style-standard-green.svg?style=flat-square)](https://github.com/feross/standard)

Advanced WebExtension generator that creates everything you need to get started with extension development.

Expand Down
7 changes: 0 additions & 7 deletions app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,13 +285,6 @@ module.exports = class extends Generator {
)
}

eslint () {
this.fs.copy(
this.templatePath('eslintrc'),
this.destinationPath('.eslintrc')
)
}

babelrc () {
this.fs.copy(
this.templatePath('babelrc'),
Expand Down
12 changes: 8 additions & 4 deletions app/templates/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,23 @@
"dev:chrome": "gulp --watch --vendor=chrome",
"dev:firefox": "gulp --watch --vendor=firefox",
"dev:opera": "gulp --watch --vendor=opera",
"dev:edge": "gulp --watch --vendor=edge"
"dev:edge": "gulp --watch --vendor=edge",
"lint": "standard"
},
"standard": {
"globals": [
"chrome"
]
},
"devDependencies": {
"babel-cli": "6.x.x",
"babel-core": "6.x.x",
"babel-eslint": "7.x.x",
"babel-loader": "7.x.x",
"babel-preset-env": "1.x.x",
"chai": "4.x.x",
"chromereload": "0.x.x",
"debounce": "1.x.x",
"del": "3.x.x",
"eslint": "^4.x.x",
"eslint-loader": "1.x.x",
"gulp": "3.x.x",
"gulp-bump": "2.x.x",
"gulp-cache": "0.x.x",
Expand All @@ -47,6 +50,7 @@
"gulp-util": "3.x.x",
"gulp-zip": "^4.x.x",
"require-dir": "0.x.x",
"standard": "^10.0.2",
"vinyl-named": "1.x.x",
"webpack": "2.x.x",
"webpack-stream": "3.x.x",
Expand Down
13 changes: 0 additions & 13 deletions app/templates/eslintrc

This file was deleted.

14 changes: 3 additions & 11 deletions app/templates/tasks/scripts.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ const ENV = args.production ? 'production' : 'development'
gulp.task('scripts', (cb) => {
return gulp.src('app/scripts/*.js')
.pipe(plumber({
errorHandler () {
// Webpack will log the errors
}
// Webpack will log the errors
errorHandler () {}
}))
.pipe(named())
.pipe(gulpWebpack({
Expand All @@ -35,14 +34,7 @@ gulp.task('scripts', (cb) => {
module: {
rules: [{
test: /\.js$/,
loader: 'eslint-loader',
exclude: /node_modules/,
enforce: 'pre'
},
{
test: /\.js$/,
loader: 'babel-loader',
enforce: 'post'
loader: 'babel-loader'
}]
}
},
Expand Down
1 change: 0 additions & 1 deletion test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ describe('chrome-extension-kickstart:app', () => {
assert.file([
'package.json',
'.editorconfig',
'.eslintrc',
'.babelrc',
'.gitattributes',
'.gitignore',
Expand Down

0 comments on commit 4e68a2d

Please sign in to comment.