fix(groups): divide task delta by number of assigned users

HabitRPG · Jun 18, 2019 · f2185a9 · f2185a9
1 parent af0cde5
commit f2185a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/website/server/controllers/api-v3/tasks.js b/website/server/controllers/api-v3/tasks.js
@@ -643,7 +643,10 @@ api.scoreTask = {
           _id: task.group.taskId,
         }).exec();
 
-        if (groupTask) await groupTask.scoreChallengeTask(delta, direction);
+        if (groupTask) {
+          const groupDelta = groupTask.group.assignedUsers ? delta / groupTask.group.assignedUsers.length : delta;
+          await groupTask.scoreChallengeTask(groupDelta, direction);
+        }
       } catch (e) {
         logger.error(e);
       }

diff --git a/website/server/middlewares/cron.js b/website/server/middlewares/cron.js
@@ -113,7 +113,8 @@ async function cronAsync (req, res) {
         }).exec();
 
         if (groupTask) {
-          const delta = Math.pow(0.9747, task.value) * -1;
+          let delta = Math.pow(0.9747, task.value) * -1;
+          if (groupTask.group.assignedUsers) delta /= groupTask.group.assignedUsers.length;
           await groupTask.scoreChallengeTask(delta, 'down');
         }
       }