Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge To-Dos Not Accurate Depiction #1751

Closed
lemoness opened this issue Nov 5, 2013 · 6 comments
Closed

Challenge To-Dos Not Accurate Depiction #1751

lemoness opened this issue Nov 5, 2013 · 6 comments

Comments

@lemoness
Copy link
Contributor

lemoness commented Nov 5, 2013

I went to go check out my competitor's progress in the Pixel challenge by clicking on their name - and was horrified to discover that they'd done every single To-Do except for the hue-shifting one!! I ran around in a panic, frantically trying to rearrange my schedule ("I'll pull an all-nighter fixing jaggies!") - until I clicked on my name, and saw that my display was identical and claimed that I, too, had completed nearly everything when in fact I had completed almost nothing. Sure enough, when I clicked on Shane's name, I saw the same thing.

The to-dos in my task list on the main page are accurate, but the progress report ones are not. This makes it difficult for me to decide exactly how much sleep I should trade for pixel art.

@Shaners
Copy link
Contributor

Shaners commented Nov 5, 2013

Yea for some reason it is just showing the last to do (so at the top) I added to the challenge for everyone when you click on them. I've tried rearranging those to dos since they were in the wrong order but it doesn't seem to stick. Going to try rearranging and changing the tag by 1 character and see what happens.

@SabreCat
Copy link
Member

SabreCat commented Nov 7, 2013

Not sure if this is the same thing I'm seeing--only the first task of each type shows up when peeking in at a participant's status. I created a Pomodoro challenge today, which looks like this (not sorted the way I wanted it to be, but that's another known issue):

screenclip

However, if I click any participant's button, I only see the top Habit and the top Daily:

screenclip

...is that the same thing? If not, I'll create a separate ticket.

@Shaners
Copy link
Contributor

Shaners commented Nov 7, 2013

Yea I believe it's the same thing.

@lemoness
Copy link
Contributor Author

lemoness commented Nov 7, 2013

Looks just like it to me.

@lefnire
Copy link
Contributor

lefnire commented Nov 11, 2013

Ah, looks like $elemMatch will only return the first matched array subdocument. I'm gonna have to use aggregation to get multiple array elements matching "in this challenge" criterion. Offending code, issue background. Don't worry, it's a benign bug - once we fix this query, things will show properly.

lefnire added a commit that referenced this issue Nov 11, 2013
application level, not Mongo. $elemMatch doesn't support returning
multiple items, see http://goo.gl/MxmWdQ & http://goo.gl/Iku44w
@lefnire
Copy link
Contributor

lefnire commented Nov 11, 2013

I pushed the fix. It has poor performance (filtering at application-level), and needs revisiting - but we'll cross that bridge later. TMK this ticket mentions two issues: (1) tasks getting copied from aggregate progress (#1729), (2) participant modals not showing all tasks. # 1 was fixed a while back, I'm closing this ticket as a fix for # 2. Re-open if I'm missing anything

@lefnire lefnire closed this as completed Nov 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants