Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending equipment modal hack to address #11015 #11070

Merged

Conversation

randi2kewl
Copy link
Contributor

This is a hack to extend another hack done by @SabreCat for issue #11015. This allows clicking on the background.

Changes

  • Added the hideDialog() call to the actual equipment modal so that it would also account for clicking on the background

UUID: 949c048a-c49b-434a-97af-cc7603082dec

@paglias
Copy link
Contributor

paglias commented Mar 21, 2019

@SabreCat leaving this one to you since it's related to some changes you made

@paglias paglias requested a review from SabreCat March 21, 2019 14:59
@SabreCat
Copy link
Member

SabreCat commented Mar 21, 2019

Good catch, @randi2kewl, and thanks for the investigation you're doing on the issue itself! This will help a bit until the underlying issue gets figured out, as it seems the equipment modal is the most common place where users run into the problem.

@SabreCat
Copy link
Member

Fixed a couple of things:

  • hideDialog() was getting called twice when the user equipped an item or clicked the X
  • Found and fixed more properties that bootstrap-vue wasn't unsetting correctly, including padding-right that led to the page body shrinking with every equip modal you popped open

Gonna go ahead and merge this for deployment today. Thanks again @randi2kewl, and welcome to the ranks of the Blacksmiths at tier 1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants