Fix broken meters in IE #4914
Merged
Fix broken meters in IE #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we took care of all the style -> ng-style conversions, but apparently not. Looks good to me! |
lefnire
force-pushed
the
develop
branch
2 times, most recently
from
4784660
to
695b00b
Compare
|
Rebased and bump, since this is a pretty significant issue. |
|
FYI, someone committed something in the last few days that has broken the travis ci build. Tracking down what it was, but the build failing doesn't mean there is anything wrong with your PR. |
|
K. Build is now passing on the develop branch. |
Health, XP, and Mana bars were broken in IE, due to the use of {{ }} within
style attributes. Using Angular's string interpolation within style attributes
doesn't work in IE, as IE will actually strip the property immediately upon DOM
render. Using ng-style allows properties to be preserved, and renders
cross-browser correctly.
|
w00t. Remerged and passing :) |
|
Eleven versions of IE and it's still a pain in the neck. Partial credit towards Tier 5. Thanks! |
|
Hah. We've run into issues with Spartan already at my day job. It never ends! 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4876
The Issue
Health, XP, and Mana bars were broken in IE, due to the use of
{{ }}withinstyleproperties. Using Angular's string interpolation withinstylepropertiesdoesn't work in IE, as IE will actually strip the property immediately upon DOM
render. Thus, the bars were rendering with no width attribute, and showed as full.
Note: See angular/angular.js#2186 for further discussion of this issue
The Fix
Using
ng-styleallows properties to be preserved, and renderscross-browser correctly.
Screenshots after the
style->ng-stylechange (pulled from my local build) are provided for convenience:IE11
Chrome
Firefox