New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pressing enter to confirm character choice in IME creates new checklist line #8334

Merged
merged 1 commit into from Jan 2, 2017

Conversation

Projects
None yet
2 participants
@changami
Copy link
Contributor

changami commented Dec 30, 2016

Fixes #8326

Changes

I changed the event from "ui-keyup" to "ui-keydown".

First, this issue was happened on OS X El Capitan and macOS Sierra.
The cause of the issue was that Enter pressing event was acquired only for "ui-keyup" at character conversion. ("ui-keydown", "ui-keypress" do not work in this case. I think this case should not trigger any key-event, including "ui-keyup", like on Windows.)

The behavior of the IME is well explained in that issue by @citrusella.

▼Before
habitica_bug_report

▼After
habitica_bug_report_after

Feedback is welcome, thank you.


UUID: 1c980e87-ef12-471b-a812-4a020cc226c1

@TheHollidayInn

This comment has been minimized.

Copy link
Collaborator

TheHollidayInn commented Jan 2, 2017

Seems straightforward to me. Thanks for the details!

Noted towards your tier. Congratz on Tier 1!

@TheHollidayInn TheHollidayInn merged commit 47bb217 into HabitRPG:develop Jan 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment