Fixes pressing enter to confirm character choice in IME creates new checklist line #8334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems straightforward to me. Thanks for the details! Noted towards your tier. Congratz on Tier 1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8326
Changes
I changed the event from "ui-keyup" to "ui-keydown".
First, this issue was happened on OS X El Capitan and macOS Sierra.
The cause of the issue was that Enter pressing event was acquired only for "ui-keyup" at character conversion. ("ui-keydown", "ui-keypress" do not work in this case. I think this case should not trigger any key-event, including "ui-keyup", like on Windows.)
The behavior of the IME is well explained in that issue by @citrusella.
▼Before
▼After
Feedback is welcome, thank you.
UUID: 1c980e87-ef12-471b-a812-4a020cc226c1