-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change user quest.progress.collect to quest.progress.collectedItems #7612
Conversation
…- NEEDS REVIEW AND TESTING
…odel to prevent failure if user collectedItems data does not yet exist
…t because I think it was unneeded and wrong
…- no idea why - REVIEW THIS ASAP
@@ -117,7 +117,10 @@ function _cleanQuestProgress (merge) { | |||
progress: { | |||
up: 0, | |||
down: 0, | |||
collect: 0, | |||
collect: {type: Schema.Types.Mixed, default: () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. Leaving a note to elaborate in a minute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed to:
collect: {},
collectedItems: 0,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed.
fix: Adjusts behavior of process collection quest
…into quest-collect-fix
@crookedneighbor