Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format fonts and colors - WiFi Wizard #431

Merged
merged 2 commits into from
Nov 19, 2021
Merged

format fonts and colors - WiFi Wizard #431

merged 2 commits into from
Nov 19, 2021

Conversation

jankrzempek
Copy link
Contributor

@jankrzempek jankrzempek changed the title format fonts and colors format fonts and colors - WiFi Wizard Nov 17, 2021
@jankrzempek jankrzempek requested review from pawelgil and smialko and removed request for pawelgil November 18, 2021 09:49
smialko
smialko requested changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@smialko smialko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D there are some leftovers from testing, please, take a look

AirCasting/CreateSessionViews/CreateSessionDetails/CreateSessionDetailsView.swift Outdated
@@ -24,7 +24,7 @@ struct CreateSessionDetailsView: View {
sessionNameField
sessionTagsField
}
if sessionContext.sessionType == SessionType.fixed { fixedSessionDetails }
if sessionContext.sessionType == SessionType.mobile { fixedSessionDetails }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added this for testing and forgot to change it back :D
Please, change it - it's not working for fixed session right now 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yees. oh my :/

AirCasting/CreateSessionViews/CreateSessionDetails/CreateSessionDetailsViewModel.swift Outdated
@@ -35,7 +35,7 @@ class CreateSessionDetailsViewModel: ObservableObject {
sessionContext.sessionName = sessionName
sessionContext.sessionTags = sessionTags

guard sessionContext.sessionType == .fixed else {
guard sessionContext.sessionType == .mobile else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, change bakc to .fixed🐝

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank U!

@smialko
Copy link
Collaborator

smialko commented Nov 19, 2021

And the rest looks ok so you can merge after those fixes :D

@jankrzempek jankrzempek merged commit c2b9eb9 into develop Nov 19, 2021
@jankrzempek jankrzempek deleted the wifi_text_update branch November 19, 2021 16:44
anna1901 added a commit that referenced this pull request Nov 22, 2021
@anna1901
Merge develop into experimental branch (#437)
4d9e5b4 
* Wizard wifi - improvement (#417)

* added ViewModel and changed the way wifi credentials are taken

* Reset thresholds to default

* format fonts and colors - WiFi Wizard (#431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smialko smialko smialko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jankrzempek @smialko