Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Registration Validation per Web's Request #170

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

lasyaneti
Copy link
Contributor

@lasyaneti lasyaneti commented Jan 23, 2024

  • Allowing array of string or undefined for dietary so web can pass [ ] in intermediary POSTs
  • Allowing gradYear undefined to avoid web passing gradYear = 0
  • Flipped proEssay and considerForGeneral validation to be for pro applicants (we care that essay len > 0) and ignore for non-pro applicants (we don't rly care if theres a field or not or if its empty or not etc)

@lasyaneti lasyaneti changed the title flipped conditional Updated Registration Validation per Web's Request Jan 23, 2024
@lasyaneti lasyaneti merged commit 51f97e3 into main Jan 23, 2024
5 checks passed
@lasyaneti lasyaneti deleted the lasya/testing-regis branch January 23, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant