Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change-update-view-to-use-put-http-method #139

Conversation

nicksonlangat
Copy link
Contributor

Since the update view is altering the state of an object in the database, shouldn't we use put method as opposed to post ? . Please review this change.

@RadoRado
Copy link
Member

@nicksonlangat Hello 👋

Sorry for the late response!

I'd say - this is entirely up to your preferences (or the preferences of the team / company / project that you are currently working in).

For me, PUT vs POST doesn't matter that much. I'd rather name the API properly (having Update in the name).

Both are fine, as long as you using it consistently.

That's why, for now, we'll leave it as simple as possible.

Let me know if you have other questions.

Cheers!

@RadoRado
Copy link
Member

RadoRado commented Nov 8, 2023

@nicksonlangat I'm closing this PR for now. Feel free to continue the discussion here, based on answer from above.

Cheers!

@RadoRado RadoRado closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants