-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react2-week1/niloufar #290
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,42 @@ | |||
#root { | |||
max-width: 1280px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using Flexbox for improved responsiveness.
const query = e.target.value; | ||
setSearchState({...searchState , error: null , isLoading : true}); | ||
try{ | ||
if( query.trim() === "" ){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to use an if-else statement; it's clearer like this:
if (query === "") {
setSearchState({ users: [], error: null, isLoading: false });
return;
}
function Users() { | ||
const {searchState} = useContext(SearchContext); | ||
return ( | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the fragment (<>...</>
) since it's not needed
No description provided.