Fix crash with non-standard time intervals (#2169, #2262) #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
- Coverage 92.10% 92.06% -0.04%
==========================================
Files 20 20
Lines 1254 1248 -6
Branches 332 328 -4
==========================================
- Hits 1155 1149 -6
Misses 40 40
Partials 59 59
Continue to review full report at Codecov.
|
…01#2262) Centers the time window on the nearest time before or equal to the active time, regardless of its hour.
saltire
force-pushed
the
fix-time-intervals
branch
from
53a1b3d
to
977e426
Compare
|
Amazing, thanks! |
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this pull request
Mar 22, 2023
…01#2262) (Hacker0x01#2350) Centers the time window on the nearest time before or equal to the active time, regardless of its hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centers the list of times on the nearest time before or equal to the active time, regardless of its hour.
Previously the code would try to center the list of times on the nearest time within the same hour. With time intervals larger than one hour, sometimes there would be no valid candidates, and the
calcCenterPositionfunction would crash.This change does a more simple comparison, and there should now always be a valid ref to a "center" list item.
Fixes #2169, #2262