Fix #4268: Retain the selected date when changing the time #4282
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@balajis-qb you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
This looks good, no changes are recommended to the current set. Nice work!
Reviewed with ❤️ by PullRequest
Codecov Report
@@ Coverage Diff @@
## main #4282 +/- ##
==========================================
+ Coverage 96.38% 96.43% +0.04%
==========================================
Files 25 25
Lines 2352 2354 +2
Branches 958 960 +2
==========================================
+ Hits 2267 2270 +3
+ Misses 85 84 -1
|
|
Can you add a test to ensure the fix keeps working? |
There was a problem hiding this comment.
This change looks good and from the description, I can see the bug in onTimeChange that initializes the date to current in original code and addressed by this change,
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
PullRequest reviewed the updates made to #4282 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.
Reviewed by:
|
Thank you for your feedback, team. I'll add the testcases and update the PR |
This commit includes two test cases for the InputTime component 1. It verifies that the component correctly triggers the onChange event when a date prop is provided. The test simulates a change in time input and checks if the expected date, based on the provided date prop and new time, is passed to the onChange function. 2. It ensures that the component gracefully handles the scenario when the date prop is missing. The test simulates a change in time input and checks if the expected date, based on the current date and new time, is passed to the onChange function when no date prop is provided. Closes Hacker0x01#4268
|
Thanks for adding the tests, please ensure the CI job is succeeding so we can get it merged. |
|
Hi @martijnrusschen , The test case failed due to an existing issue there in the datepicket_test.test.js file. Please check the issue I created for more details #4283 I fixed the issue and updated this PR. Kindly review and let me know if any changes required |
|
It was my pleasure. Thank you for your kind words. |
Closes #4268
Summary
This PR addresses an issue where the component was resetting the selected date of the component to the current date when changing the time. The fix ensures that the selected date remains unchanged when modifying the time, enhancing the user experience.
Changes Made