Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4268: Retain the selected date when changing the time #4282

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Fix #4268: Retain the selected date when changing the time #4282

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c9a350
Fix: Retain the selected date when changing the time
Sep 29, 2023
4121ff6
Test: Ensure InputTime component handles specified date prop correctly
Oct 1, 2023
2831b94
Merge branch 'main' into issue-4268/fix/retain-selected-date-on-time-…
Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/inputTime.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,14 @@ export default class inputTime extends React.Component {

onTimeChange = (time) => {
this.setState({ time });
const date = new Date();

const { date: propDate } = this.props;
const isPropDateValid = propDate instanceof Date && !isNaN(propDate);
const date = isPropDateValid ? propDate : new Date();

date.setHours(time.split(":")[0]);
date.setMinutes(time.split(":")[1]);

this.props.onChange(date);
};

Expand Down