Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Add coverage badge #206

Merged
merged 2 commits into from
May 10, 2017

Conversation

renatomassaro
Copy link
Member

@renatomassaro renatomassaro commented May 10, 2017

@mememori I've also replaced true/false with uft8 marks, which I think makes the table clearer (less bloated). Take a look at the diff, what do you think?

Also, just to state my opinion, I think the first line of the README should be Helix. It's more standard/expected behavior when compared to other repos. But personally, I don't care 😊


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 59.977% when pulling 067d88c on renatomassaro:coveralls-badge into 4a98334 on HackerExperience:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 59.688% when pulling 1075c72 on renatomassaro:coveralls-badge into 4a98334 on HackerExperience:master.

@renatomassaro
Copy link
Member Author

I'll remove coveralls comments because they will flood longer PRs.
Coveralls status check will fail if total coverage drops below 50% or pr changes decrease total coverage in 10%. Once we get a better coverage we can optimize these numbers (100% coverage is usually overkill, 90% is a nice threshold)

@umamaistempo
Copy link
Contributor

OTP
:shipit: lgtm :shipit:

@umamaistempo umamaistempo merged commit d09232e into HackerExperience:master May 10, 2017
@renatomassaro renatomassaro deleted the coveralls-badge branch May 10, 2017 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants