Gifted Stickers for incomplete users

[fridaland]

Distributing remaining sticker coupons

A new state will be added to the user state machine (gifted_sticker), to distribute all remaining sticker coupons. This will include:

• Validating the user upon transitioning from incomplete -> gifted_sticker
• Appropriate Segment calls to fire email events
• Background job to transition users based off of how many scoring PRs they have. We want to transition based on:
  • Highest # of PRs
  • Ordered by earliest created_at time of the latest pull request

Test process

• Test new gifted_sticker state
• Test validation for coupon presence for new state in even machine
• Test transition for a user in the incomplete state to gifted_sticker
• Test service GiftStickersService that will assign user a sticker coupon

Open Source contributing guidelines

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[johndbritton]

Ordered by earliest created_at time

This should be more specific. Ordered by earliest created_at time of the latest pull request.

u.scoring_pull_requests.max_by(&:created_at).created_at

[jhaff]

Of note: it's odd that we did not have to stub the UserStateTransitionSegmentService in the gift_stickers_service_spec because ultimately, the GiftStickerService is causing transitions, which should cause the UserStateTransitionSegmentService to be called

[johndbritton]

Looking good. Few things to be renamed and some minor fixes. Probably will need one or two more rounds.

[johndbritton]

This starter data should be updated to reflect the logic that a user with the earliest date on their latest PR should be ranked first for users with that number of PRs.

[fridaland]

This is actually already the case. My main mistake was just grabbing the first created PR per user as opposed to the last in the GiftService . However, the user with the earliest date on their latest PR will always be ranked first. So if there is only one coupon user_with_early_receipt_3prs (meaning user with score of 3, who's last PR has earliest PR created_at time) will be the one getting the coupon.

[fridaland]

Since we can't run CI

[johndbritton]

Just a couple questions