Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Fix bad conditional transition event check for 'gifted' segment calls #439

Merged
merged 8 commits into from
Nov 18, 2019

Conversation

fridaland
Copy link
Contributor

@fridaland fridaland commented Nov 18, 2019

Description

#437 introduced a bad conditional check in the UserStateTransitionSegmentService.
As a result, no segment calls were made.

Test process

  • Modify tests accordingly, looking for gifted event
  • Stub Segment calls in appropriate tests

Requirements to merge

  • Replace gift_sticker with gifted
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@johndbritton johndbritton merged commit 53c6f91 into Hacktoberfest:master Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants