Fix BAMSplitGuesser to check that read name is of length one or more. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilveroluca
added a commit
that referenced
this pull request
Oct 22, 2015
Fix BAMSplitGuesser to check that read name is of length one or more.
|
Thanks Tom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when reading BAM files without an index that was found in broadinstitute/gatk#1005. The problem is that the heuristics in BAMSplitGuesser are not strong enough and in some cases can return a position that is not the start of a BAM record. The test in this PR fails for the existing BAMSplitGuesser; it passes with the fix.