This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
[NA] Add service-tooling Linting + TSConfig #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rypete
requested review from
pjbroadbent,
tomrobertsOF,
bryangaleopenfin,
ottah and
MichaelMCoates
bryangaleopenfin
approved these changes
Apr 1, 2019
| "docs:api": "typedoc --name \"OpenFin Layouts\" --theme ./typedoc-template --out ./dist/docs/api --excludeNotExported --excludePrivate --excludeProtected --hideGenerator --readme DOCS.md --tsconfig src/client/tsconfig.json --readme none", | ||
| "docs:config": "bootprint json-schema ./res/provider/config/layouts-config.schema.json ./dist/docs/config", | ||
| "docs": "npm run docs:api && npm run docs:config", | ||
| "fix": "gts fix && cd test && gts fix", | ||
| "fix": "svc-tools fix", |
There was a problem hiding this comment.
I'm assuming svc-tools fix cd's into the test directory?
There was a problem hiding this comment.
MichaelMCoates
approved these changes
Apr 3, 2019
added 4 commits
April 8, 2019 16:54
added 9 commits
April 8, 2019 16:55
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds eslinting + tsconfig extension from
service-tooling. No linting has been run yet. Will do that after everyone has had a chance to look at the base changes and after existing PRs are merged in.Also adds a vsc settings file to configure the eslint vsc extension
Tests are passing locally