Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] add support to PHP 8 attributes #1567

Closed
azjezz opened this issue Dec 31, 2020 · 2 comments
Closed

[feature-request] add support to PHP 8 attributes #1567

azjezz opened this issue Dec 31, 2020 · 2 comments

Comments

@azjezz
Copy link

azjezz commented Dec 31, 2020

I have upgraded one of my projects to PHP 8 and noticed that routes declared using PHP 8 attributes are not recognized by this plugin.

I'm not sure if this issue has already been reported, but I searched and couldn't find one :)

example:

<?php

declare(strict_types=1);

namespace App\Controller;

use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

final class IndexController
{
    #[Route("/", name: 'index', methods: ['GET'])]
    public function index(): Response
    {
        // some code
    }
}
Haehnchen added a commit that referenced this issue Jan 23, 2021
#1567 support routes definition inside PHP8 attributes
@Haehnchen
Copy link
Owner

its now supported

@azjezz
Copy link
Author

azjezz commented Jan 23, 2021

Thank you for your work @Haehnchen! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants