Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React command clic disabled #2153

Closed
nitrique opened this issue May 11, 2023 · 11 comments
Closed

React command clic disabled #2153

nitrique opened this issue May 11, 2023 · 11 comments
Labels

Comments

@nitrique
Copy link

Hi,

Starting today, I have an issue when using this plugin with a .tsx file open.

The JSX code is not analyzed correctly and I cannot command + clic to follow render object definition.
When I set an attribute on JSX tag, instead of autocompleting with {} I get ""

I think it disable the JSX and analyze the file as regular HTML instead.

When I turn of the plugin, the problem disappear and I can go to the component definition.

Version of the plugin : 2022.1.248
Version of IntelliJ IDEA 2023.1.1 (Ultimate Edition) : Build #IU-231.8770.65, built on April 27, 202

Best regards,
Nicolas

@Haehnchen
Copy link
Owner

i can only think of #2148 causing this, but looking fine on jsx files for me. neverless i reduced the logic to handle only on Twig files now.
maybe a screenshot would be possible from your side?

what also would be possible, after updating a plugin reloading all plugins is failing, because its not working smooth with licensed plugins like here. restart of phpstorm needs be done manually then.

Haehnchen added a commit that referenced this issue May 11, 2023
#2153 reduce activation scope for injected Twig html implementation
@yura3d
Copy link

yura3d commented May 11, 2023

Today got the same behavior for *.tsx files after the plugin was updated to 2022.1.248.

PhpStorm has setting to set what autocompletion should be used for JSX attributes (defaults to braces):

image

And it works fine (adds curly braces after entering "=") when Symfony plugin is disabled:

braces-symfony-disabled

But when Symfony plugin is enabled, it always adds quotes:

braces-symfony-enabled

@nitrique
Copy link
Author

Today got the same behavior for *.tsx files after the plugin was updated to 2022.1.248.

PhpStorm has setting to set what autocompletion should be used for JSX attributes (defaults to braces):

image

And it works fine (adds curly braces after entering "=") when Symfony plugin is disabled:

braces-symfony-disabled

But when Symfony plugin is enabled, it always adds quotes:

braces-symfony-enabled

The may problem IMO is not about the braces, but the command click and the import issue.

Here is the video record : plugin-issue (will be available for 1 month)

Thanks :)

@rushi
Copy link

rushi commented May 12, 2023

Happening to me too! I have two components in the same file, and they don't see each other. PHPStorm's tell me it's not used. Took me a while to figure it out that it was the Symfony plugin causing the problem.

Edit: I'm using PHPStorm and my file is .jsx - I used PHPStorm with no plugins to test this out, as soon as the Symfony plugin is installed this problem occurs

Screenshot 2023-05-12 at 20 21 43@2x

@yura3d
Copy link

yura3d commented May 13, 2023

As a temporary solution, I've installed the previous version (2022.1.247), and all JSX problems have gone away.

@rushi
Copy link

rushi commented May 13, 2023

@yura3d How do you install a previous version of a plugin in the IDE?

@yura3d
Copy link

yura3d commented May 13, 2023

@rushi It is described in the docs:

To install a specific version, go to the plugin page in the JetBrains Plugin Repository, download and install it as described in Install plugin from disk. For example, you can do it if the most recent version of the plugin is broken.

I removed the current version, downloaded zip archive of previous version and installed it through Plugins section menu in Settings window. The license (I use paid plugin version) was applied automatically.

@rushi
Copy link

rushi commented May 13, 2023

Thank you @yura3d

@nitrique
Copy link
Author

Just got an update which fixed the issue, thanks.
If no one remain with issue, it can be closed :) .

@marekopatril
Copy link

Yes, its working since 2022.1.249 update today

@Haehnchen
Copy link
Owner

thanks for feedback and validation. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants