Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't report standalone colon in mapping value #733

Merged
merged 1 commit into from
May 24, 2016

Conversation

xabbuh
Copy link
Contributor

@xabbuh xabbuh commented May 24, 2016

Colons in mapping values are fine as long as they are not followed by a
space character.

@xabbuh
Copy link
Contributor Author

xabbuh commented May 24, 2016

see symfony/symfony-docs#6604

Colons in mapping values are fine as long as they are not followed by a
space character.
@xabbuh
Copy link
Contributor Author

xabbuh commented May 24, 2016

Hm, looks like something's still going wrong with my tests.

@stof
Copy link
Contributor

stof commented May 24, 2016

I think the YAML parser used by PHPStorm does not parse foo: bar: test as foo: 'bar: test' but as foo: {bar: test} (which cannot be considered as a bug, as the YAML spec does not define how parsers should fallback for invalid input, unlike HTML5, and so the parser is accepting a different kind of value here). This probably mean that it never sees a bar: test unquoted value (meaning that the detection of the deprecation might be much harder to implement)

@Haehnchen Haehnchen merged commit 07a5f86 into Haehnchen:master May 24, 2016
Haehnchen added a commit that referenced this pull request May 24, 2016
@Haehnchen
Copy link
Owner

yes, PhpStorm parse it in a different way, but some whitelist magic helps here

@xabbuh xabbuh deleted the patch-1 branch May 24, 2016 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants