Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace import and support Angular Material 12 #20

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

parse
Copy link
Contributor

@parse parse commented May 25, 2021

Fixes #18

@HaidarZ
Copy link
Owner

HaidarZ commented May 25, 2021

Much appreciated, will review the changes and merge asap.

@zach-snell
Copy link

@HaidarZ couple of us on my project took a look at the changes yesterday. They look reasonable and the constant is identical to Angular 12 which just no longer exposes it publically.

Can you merge this in? Thanks!

Copy link
Owner

@HaidarZ HaidarZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use import {SELECT_ITEM_HEIGHT_EM} from '@angular/material/select/select'; instead of declaring a new constant.
Most probably SELECT_ITEM_HEIGHT_EM have been removed from the public api by mestake.
angular/components#22787

@zach-snell
Copy link

@HaidarZ Looks like Angular replied on the linked thread that the removal was intentional and completion of API that were marked deprecated and to be removed in 12.

@jawaddev
Copy link

jawaddev commented Jun 1, 2021

@HaidarZ any updates on when this will be merged? as @zach-snell said it was the removal was intentional.

@angelaki
Copy link

angelaki commented Jun 1, 2021

Guess you are still hoping for a more satisfactory answer from the Angular Team than just assume 3?

@HaidarZ
Copy link
Owner

HaidarZ commented Jun 1, 2021

Sorry guys,I was trying to stick to the flow and standards.
There's no official deprecation notice or comment inside the docstring.
Typically they must inform users that in the next release the following must be removed.
Anyways, the wait is over. Thanks for your patience.

@HaidarZ HaidarZ merged commit a2a5f65 into HaidarZ:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular and material 11 support.
5 participants