Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RCNZ models #152

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Update RCNZ models #152

merged 2 commits into from
Mar 20, 2024

Conversation

ResidentChief
Copy link
Contributor

Remove two old models, update both 1.5 and SDXL versions of ICBINP

@db0
Copy link
Member

db0 commented Mar 20, 2024

Is Gorilla obsolete? I thought people were still using it. Otherwise LGTM

@ResidentChief
Copy link
Contributor Author

Yeah.. it was the predecessor to the whole ICBINP line, which is now 13-14 versions in

@db0
Copy link
Member

db0 commented Mar 20, 2024

Oh, I was always under the impression the Gorilla was meant to be more like an artistic/stylistic model and not a photorealistic one.

@ResidentChief
Copy link
Contributor Author

Nah.. Monkey was supposed to be the artsy one, and gorilla started with the photorealism

@db0
Copy link
Member

db0 commented Mar 20, 2024

@tazlin removing these two models will just result in those workers currently hosting them to receive some warnings until they remove them from their lists, rights?

@tazlin
Copy link
Member

tazlin commented Mar 20, 2024

@tazlin removing these two models will just result in those workers currently hosting them to receive some warnings until they remove them from their lists, rights?

That is my belief. I don't recall workers crashing/going offline during the last purge of models. This would be predicated on the api still issuing jobs along side the 'unfortunately we cannot accept workers offering unrecognized models' message.

@db0
Copy link
Member

db0 commented Mar 20, 2024

The API will silently drop unrecognised models actually, so long as you have another model that is recognised in your list. OK so good to merge

@db0
Copy link
Member

db0 commented Mar 20, 2024

@ResidentChief you're finished with this PR, ye?

@ResidentChief
Copy link
Contributor Author

ResidentChief commented Mar 20, 2024 via email

@db0 db0 merged commit cf6e869 into Haidra-Org:main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants