Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arhiver for Haiku #1

Closed
wants to merge 15 commits into from
Closed

Arhiver for Haiku #1

wants to merge 15 commits into from

Conversation

punsith
Copy link

@punsith punsith commented Jan 5, 2017

No description provided.

@scottmc
Copy link
Member

scottmc commented Jan 5, 2017

There is an option in Paladin to export a Makefile. Do that and then the compiling step might be as easy as running "make".

@punsith
Copy link
Author

punsith commented Jan 5, 2017

okay :)

@punsith
Copy link
Author

punsith commented Jan 11, 2017

i updated :)

@richienyhus
Copy link

@scottmc & @waddlesplash any further changes needed ?

@@ -51,7 +51,7 @@ SOFTWARE
#include <View.h>
#include <Window.h>

#include <be/add-ons/tracker/TrackerAddon.h>
#include </boot/system/develop/headers/os/add-ons/tracker/TrackerAddOn.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, keeping just <add-ons/tracker/TrackerAddOn.h> should work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm but it didn't compiled
"boot/home/Archiver/Source/Archiver.h:54: /add-ons/tracker/TrackerAddOn.h: No such file or directory
/boot/system/develop/etc/makefile-engine:291: recipe for target 'objects.x86-gcc2-release/Archiver.o' failed
make: *** [objects.x86-gcc2-release/Archiver.o] Error 1
"

@@ -63,7 +63,7 @@ SOFTWARE

#define ARCHIVER_SETTINGS_FILE_PATH "/boot/home/config/settings/"
#define ARCHIVER_SETTINGS_FILE "archiver.settings"
#define ARCHIVER_RULES_FILE_PATH "/boot/home/config/etc/"
#define ARCHIVER_RULES_FILE_PATH "/boot/home/config/non-packaged/etc/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to look in the packaged directory? Or does it try to write here?
Ideally we should look in both but it is out of the scope of your task

Copy link
Author

@punsith punsith Jan 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user should paste the rules file to that location but the program don't use the file on that location as Pete Goodeve said , it using rules file in " B_SYSTEM_ETC_DIRECTORY" . and also user should paste rules file on their but if I comment that path it won't compile :/ but when i delete the rules file from non-packaged nothing changed :/ it works fine

/boot/system/settings/etc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is where it goes? If it is a tracker add-on, then the proper place would be /boot/home/config/non-packaged/add-ons/Tracker

@scottmc
Copy link
Member

scottmc commented Jan 27, 2017

Any progress on cleaning this up?

@punsith
Copy link
Author

punsith commented Jan 27, 2017

@scottmc
"ARCHIVER_RULES_FILE_PATH "/boot/home/config/non-packaged/etc/""
is something I cant understand. The archiver don't us the location above. It using .rules file in B_SYSTEM_ETC_DIRECTORY. but if I dete the that code it wont work.

@scottmc scottmc closed this Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants