Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Size" test could be more sophisticated #63

Closed
humdingerb opened this issue Jul 13, 2017 · 5 comments
Closed

"Size" test could be more sophisticated #63

humdingerb opened this issue Jul 13, 2017 · 5 comments

Comments

@humdingerb
Copy link
Member

Currently the user has to enter the file size in bytes. It'd be nice if the test could look for "k" or "K", "m" or "M" and "g" or "G" to use kilo, mega, giga bytes in its comparisson.

Until then, the "Size" test should be more specifically named "Size (in bytes)", I guess.
@humdingerb
Copy link
Member Author

If at all possible, the size unit would best be done with a dropdown menu after the text control showing localized "KiB", "MiB", "GiB" and, why not, "TiB".

@owenca
Copy link
Contributor

owenca commented Jul 14, 2017

Good idea! I have created a related issue #64.

@owenca
Copy link
Contributor

owenca commented Jul 16, 2017

It's half way there, but I might not be able to work on Haiku for a few days.
1of2
2of2

owenca added a commit to owenca/Filer that referenced this issue Jul 17, 2017
@owenca
Fixes issue HaikuArchives#63:
7b13957 
Adds support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, looks for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.
owenca added a commit to owenca/Filer that referenced this issue Jul 17, 2017
@owenca
Fixes issue HaikuArchives#63:
0f0f022 
Add support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, look for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.

Recode TestView to simply logic and make it better organized.
owenca added a commit to owenca/Filer that referenced this issue Jul 17, 2017
@owenca
Fixes issue HaikuArchives#63:
503b270 
Add support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, look for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.

Recode TestView to simply logic and make it better organized.
owenca added a commit to owenca/Filer that referenced this issue Jul 17, 2017
@owenca
Fixes issue HaikuArchives#63:
9c08b5d 
Add support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, look for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.

Recode TestView to simply logic and make it better organized.
owenca added a commit to owenca/Filer that referenced this issue Jul 18, 2017
@owenca
Fixes issue HaikuArchives#63:
fd0f39a 
Add support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, look for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.

Recode TestView to simply logic and make it better organized.
owenca added a commit to owenca/Filer that referenced this issue Jul 18, 2017
@owenca
Fixes issue HaikuArchives#63:
10a49b4 
Add support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, look for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.

Recode TestView to simply logic and make it better organized.
humdingerb pushed a commit that referenced this issue Jul 18, 2017
@owenca
Fixes issue #63:
4432990 
Add support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, look for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.

Recode TestView to simply logic and make it better organized.
@owenca
Copy link
Contributor

owenca commented Jul 20, 2017

I have created a follow-up issue (#74). Close this one?

@humdingerb
Copy link
Member Author

Right, thanks.

humdingerb pushed a commit to humdingerb/Filer that referenced this issue Aug 12, 2017
@owenca
Fixes issue HaikuArchives#63:
2b8dfaf 
Add support for file size units (bytes, KiB, MiB, GiB, and TiB).

Also, look for . and .. when deciding if the user has
given a folder path to the "Add to archive" action.

Recode TestView to simply logic and make it better organized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humdingerb @owenca