-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow factional numbers in the text control for size tests. #74
Comments
Fixes part of issue HaikuArchives#74.
It seems Haiku doesn't support locale-sensitive decimal mark. |
Until we can find a solution, why not allow "." and "," in the size text control, and when saving the rule, replace the "," with a "." before converting to a float if that isn't done automatically? When loading the rule, you can do something like the following to localize the rule's size float:
|
…est. Fixes issue HaikuArchives#74 more.
The user can enter either |
Pulkomandy is implementing |
Well, It turns out that I don't have to use |
I think it works well enough. Just for completeness, I mention what could be improved (probably once Parse() exists): People currently cannot use 1000-delimiters, e.g. 1,234.56 (or German: 1.234,56). It's not crucial, but what separates Filer from perfection. :) Let's mark this fixed then with #76 . Thanks! |
Fixes part of issue HaikuArchives#74.
The decimal mark should be disallowed for the "bytes" unit and localized to either '.' or ',' depending on the current locale.
Also, dragging & dropping a file should set the text to a value and unit that makes the most sense, e.g., 1.23 MiB instead of 1259.52 KiB or even worse, 1289748 bytes.
The text was updated successfully, but these errors were encountered: