Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Minor adjustments for sync timing compliance #1269

Merged

Conversation

maxsharabayko
Copy link
Collaborator

During the development, some parts of the SRT sync lost their compatibility with the corresponding STD chrono API.
This PR brings compliance back.
It mainly changes checking for empty (zero) timepoint.

Changes extracted from #1266 that introduces C++11 STD chrono build option.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels May 5, 2020
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone May 5, 2020
@maxsharabayko maxsharabayko added this to Backlog in Development via automation May 5, 2020
@maxsharabayko maxsharabayko force-pushed the develop/sync_09_1_timepoint_zero branch from 302a71a to 47074ed Compare May 5, 2020 10:44
srtcore/core.h Outdated Show resolved Hide resolved
srtcore/buffer.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider:

with STD chrono API. Mainly changes checking for empty (zero) timepoint.
@maxsharabayko maxsharabayko force-pushed the develop/sync_09_1_timepoint_zero branch from 47074ed to dbce588 Compare May 5, 2020 12:03
Development automation moved this from Backlog to Reviewer Approved May 5, 2020
@maxsharabayko maxsharabayko merged commit 2cdc4d2 into Haivision:master May 5, 2020
Development automation moved this from Reviewer Approved to Done May 5, 2020
@maxsharabayko maxsharabayko deleted the develop/sync_09_1_timepoint_zero branch May 5, 2020 13:44
@maxsharabayko maxsharabayko mentioned this pull request May 5, 2020
18 tasks
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
No open projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants