Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SRT build option for building with C++11 chrono and threads #1266

Merged
merged 4 commits into from
May 8, 2020
Merged

Adding SRT build option for building with C++11 chrono and threads #1266

merged 4 commits into from
May 8, 2020

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Apr 30, 2020 •
edited

  • Fixed C++11 build
  • Renamed ENABLE_STDCXX_CHRONO to ENABLE_STDCXX_SYNC
  • Added ENABLE_STDCXX_SYNC CMake build option
  • Unittests fixed for the case ENABLE_STDCXX_SYNC=ON

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [core] Area: Changes in SRT library core labels Apr 30, 2020
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone Apr 30, 2020
@maxsharabayko maxsharabayko changed the title Develop/sync 09 cxx11 build Adding SRT build option for building with C++11 chrono and threads Apr 30, 2020
@maxsharabayko maxsharabayko mentioned this pull request May 5, 2020
Merged
@maxsharabayko maxsharabayko force-pushed the develop/sync_09_cxx11_build branch 2 times, most recently from aea0dc1 to 2398b59 Compare May 5, 2020 13:55
ethouris
ethouris reviewed May 7, 2020
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
ethouris
ethouris reviewed May 7, 2020
View reviewed changes
srtcore/sync.cpp Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko force-pushed the develop/sync_09_cxx11_build branch 3 times, most recently from 9ffe385 to 61763fa Compare May 7, 2020 11:27
@maxsharabayko maxsharabayko marked this pull request as ready for review May 7, 2020 11:28
ethouris
ethouris reviewed May 7, 2020
View reviewed changes
srtcore/sync.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed May 7, 2020
View reviewed changes
test/test_sync.cpp Outdated Show resolved Hide resolved
@maxsharabayko
Copy link
Collaborator Author

Fixed CMakeLists.txt alignment ^^^

@maxsharabayko maxsharabayko merged commit 4c71d90 into Haivision:master May 8, 2020
@maxsharabayko maxsharabayko deleted the develop/sync_09_cxx11_build branch May 8, 2020 09:13
@maxsharabayko maxsharabayko mentioned this pull request May 8, 2020
Closed
18 tasks
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndi rndi rndi approved these changes

@ethouris ethouris ethouris approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxsharabayko @rndi @ethouris @mbakholdina